-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an uber-department #1019
Add an uber-department #1019
Conversation
@pirj |
@dmytro-savochkin Ah, I've missed that. Thanks a lot for the heads-up! Going to fix this shortly. |
de0d137
to
59e0aab
Compare
@pirj I force-pushed to this branch, but the build is still failing. I’ll have a look at it later today. |
I think I fixed it :-) |
Thanks! LGTM. |
dccde97
to
7d20a20
Compare
I think we’re ready to merge. |
7d20a20
to
fac31fd
Compare
To avoid name and department clash issues, RuboCop decided to grant each extension its own department. For those cops that already have the department matching the extension name, no changes are needed. More info rubocop/rubocop#8490 The changed cop names are: * `Capybara/CurrentPathExpectation` -> `RSpec/Capybara/CurrentPathExpectation` * `Capybara/FeatureMethods` -> `RSpec/Capybara/FeatureMethods` * `Capybara/VisibilityMatcher` -> `RSpec/Capybara/VisibilityMatcher` * `FactoryBot/AttributeDefinedStatically` -> `RSpec/FactoryBot/AttributeDefinedStatically` * `FactoryBot/CreateList` -> `RSpec/FactoryBot/CreateList` * `FactoryBot/FactoryClassName` -> `RSpec/FactoryBot/FactoryClassName` * `Rails/HttpStatus` -> `RSpec/Rails/HttpStatus`
fac31fd
to
ccf11f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this is my first visit to rubocop-rspec code, this looks fairly safe to change (LGTM). I also think it is a good call in the changelog to call it "potentially breaking" although it is unlikely to be clashing with other rubocop extensions.
If I understand correctly, if you have configured these cops in your own .rubocop.yml/.rubocop_todo.yml, then you MUST also rename it there.
I would reckon it would help users to call this a breaking change. Good call 👍 .
@jesperronn We have a comprehensive document describing all the breaking changes in the 2.0 release and the migration procedure, you may check #1013 if you're interested. |
To avoid name and department clash issues, RuboCop decided to grant each extension its own department.
More info rubocop/rubocop#8490
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).Rails/PersistenceCalledOutsideExample
CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).